OpenTelemetry ETW Exporter #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=======================================
+ Coverage 51.0% 51.9% +0.9%
=======================================
Files 34 37 +3
Lines 4358 4896 +538
=======================================
+ Hits 2223 2544 +321
- Misses 2135 2352 +217 ☔ View full report in Codecov by Sentry. |
lalitb
reviewed
Jan 4, 2024
hdost
reviewed
Jan 16, 2024
hdost
reviewed
Jan 16, 2024
There was a problem hiding this comment.
Might want to make sure we have some windows testing in place for ETW
Example: https://github.com/rust-lang/rustfmt/blob/master/.github/workflows/windows.yml
psandana
force-pushed
the
feat/opentelemetry-etw-logs
branch
2 times, most recently
from
79bcc39
to
541797d
Compare
psandana
force-pushed
the
feat/opentelemetry-etw-logs
branch
from
85cf5ea
to
652747d
Compare
psandana
force-pushed
the
feat/opentelemetry-etw-logs
branch
from
7c37a47
to
1018495
Compare
cijothomas
reviewed
Mar 14, 2024
cijothomas
reviewed
Mar 14, 2024
cijothomas
reviewed
Mar 14, 2024
cijothomas
reviewed
Mar 15, 2024
cijothomas
reviewed
Mar 15, 2024
cijothomas
reviewed
Mar 15, 2024
cijothomas
reviewed
Mar 15, 2024
cijothomas
reviewed
Mar 15, 2024
cijothomas
approved these changes
Mar 15, 2024
lalitb
reviewed
Mar 15, 2024
| "registry", | ||
| "std", | ||
| ] } | ||
| microbench = "0.5" |
There was a problem hiding this comment.
nit - Is there a particular reason we're leaning towards microbench rather than criterion, as otel-rust mainly sticks with criterion? Just curious, as it doesn’t necessarily mean we can’t explore using it here. :)
lalitb
reviewed
Mar 15, 2024
…dana/opentelemetry-rust-contrib into feat/opentelemetry-etw-logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Design discussion issue (if applicable)
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes